Paul Wong-Gibbs 11:55 pm on February 24, 2014
Tags: 5220 ( 5 ), 5374 ( 2 ), weekly updates ( 9 )

#weekly-updates time! As I write,…

#weekly-updates time! As I write, it’s only about 303 days to Christmas, and about 30 days until the scheduled date for 2.0 beta 1. For people who are contributing towards specific tickets for 2.0, how are they going? Please post a status update here prior to Wednesday’s dev chat. Thanks!

#5220, #5374

Tammie Lister 10:41 am on February 25, 2014
Team template has reached the end of the sprint. Most things got a look but one thing is still outstanding and that is messages. This entire area needs some major work.

I will not be able to make this week’s dev chat – or at least it’s highly unlikely as I’ll be away. As a result and because of the urgency of messages, I have suggested @hnla takes the floor with messages and works through any issues in the meeting. I hope this is possible as we need a decision on if messages happens or not by the end of this week. We have a cut off of Friday for this – we can’t let things go on with this many days left.

As a point of note, from here on in, we need to be firm about dates. I am more than happy to cut out work to get 90% or 80% of the template pack in for 2.0. Whatever happens, this isn’t going to go on for another cycle.

This week
- Issue triage
- Fine tooth comb the templates to wrap up into beta as much as possible
- Begin device testing
- Blog templates – I’ve got these locally but not pushed yet
- hnla 7:02 pm on February 26, 2014
  In respect of ‘Messages’ I had a catchup with @trishasalas yesterday to discuss what we saw as the various issues in approaching this task. Briefly they fell into two main areas.
  - Re-factoring of core messages template to provide new functions or arguments for loops
  - A difficulty in knowing quite how the various ‘views’ needed to be managed on page actions
  Despite a new function provided to fetch a full message body as opposed to just an extract this just serves the messages loop, in terms of ability to display content to the right side or column this is harder to determine as there is no means to pull a single message outside of single message template having been called via a thread title link to pass a message id value across.
  
  So what would be required to be able to proceed with this is, and as requested, a discussion to flesh out and clarify the wireframe in more detail so it’s clear to what ends we are working towards & most probably some further detailed re-factoring of core messages class/template – this aspect might not be justified as it may become a fair bit of work ultimately prompting a fuller necessity for a rewrite of the messages core altogether.
  
  Alternatively I have had a faux set of reworked template that attempt to get to some stage that begins to replicate the wireframe; this consists of:
  
  Re-factoring messages.php switch to mix & merge template loop and single message view.
  
  On the initial messages top level ‘inbox’ we display a left column full messages loop (inbox shows received ‘from’ messages, sentbox shows messages ‘To’) on the right side I show a message puling in messages/single.php in the single template I test for the current action and if is ‘inbox’ I pass ‘&thread_id=8’ and break the while loop after the first iteration to produce a view – in theory – of what would be the last message received (either read or unread) Selecting a tread title from the left column thread takes us too single view but now we would see the full message thread in the right column.
  
  To fake this I have hardcoded a message thread id so for this to work we would need to be able to pass some means of request for the last message received or sent via bp_thread_has_messages(‘&message_thread=last’).
  
  Both inbox & true single message view display the compose form beneath the messages on the right.
  
  This is not intended as a solution but as a nudge in the right direction although in a possibly revised take on things.
imath 10:51 pm on February 25, 2014
My week :
- i’ve worked on 921 (Group members sorting & search box), 5328 (HeartBeat new activities check) with @boonebgorges and thanks to him, these are now 2 new features of next 2.0 !!
- i’ve worked with @boonebgorges on 5374 : new Sign-ups Administration screen. I’ve tested it on different configs (Multisite BuddyPress network activated and not and non multisite) and it seems to work fine. It would be great to have more feedbacks on this. I think it would be a nice improvement not only to BuddyPress but also to WordPress as for now, there is no way to manage signups. I really hope this feature will be in 2.0.
- i’ve just posted 5429, a ticket about my idea of managing attachments for BuddyPress components. Depending on your feedbacks, i’ll keep on working on it for a couple of weeks.
Next week, i’ll keep on working on #5374 to improve the way the resend functionnality works following @boonebgorges ‘s idea about it.
Boone B. Gorges 2:54 pm on February 26, 2014
- Spent much of my time helping others with patches.
  - 5416 lenasterg and saving some queries in the group loop
  - 5144 r-a-y and hnla on the placement of the Create a Group button by theme compat
  - 921 (oldie but goodie!) imath and ‘type’ parameter for bp_group_has_members() and sorting on the group members screen
  - 5328 imath and the Load Newest heartbeat feature for the activity stream
  - 5421, 5422, 5423 dcavins on group invitation sorting and invitation workflow improvements
  - 5374 imath and signups (moving BP to wp_signups for non-multisite + the new Signups admin panel)
- Improvements to group caching 5407
- Added a bunch of unit tests related to items discussed above
- Posted about ‘last_activity’ changes.
Over the next week, I plan to continue working with other people’s patches as a first priority. If I get time, I want to review and commit 4636, which reinstates the “Boone’s profile was updated” activity item. I’m also going to prioritize 5296 (Repair tools), because there’s a good patch, and because a number of changes made during this dev cycle so far could really benefit from having tools there. I’m also still thinking about improvements to our metadata functions, and will do a writeup as soon as I can: 5399.
Paul Gibbs 6:30 pm on February 26, 2014

I’m about done on #5220. There’s one or two small niggly pieces that probably should be tidied up but I think it’s close to done, and definitely ready for feedback. I’ll write up on the ticket about what/how it’s changed sometime this week, and then I’ll probably look at unit test coverage and building a dummy plugin to check if I’ve missed anything that a custom field type would need to be able to change.
Ray 6:39 pm on February 26, 2014
Worked on a few bugfixes and patches:
- 5404 – AJAX pagination for pages greater than 1000.
- 5413 – Don’t query item counts unnecessarily when a component runs its setup_nav() method.
- 5419 – Patch to add object caching when grabbing the active notice. (Pretty much going to commit this.)
- 5418 – Patch to fix theme compatibility when a theme looks up the post type before loading its templates.
Next week, going to work on object caching all item counts associated with the adminbar (5414). Might work on a second pass at rewrite rules to use add_rewrite_tag() and add_rewrite_rule() instead of hooking on to the 'generate_rewrite_rules' filter (4954). We should look at implementing a first pass at rewrite rules in early March so we have time to address issues.