Dev Chat Summary for September 7, 2016

BuddyPress 2.7

Trac Tickets

Groups query overhaul (#5451) @boonebgorges has patch to boost performance and object caching for the Groups component. He noted, “There will be some backward compatibility breaks for anyone using `bp_groups_get_(paged|total)_groups_sql` filters and has listed some plugins in ticket. Dev feedback requested –  especially @djpaulgibbs and @rayisme ( @dcavins has already voiced his support 🙂  )” @rayisme has posted support as well. Update: This is now in trunk.

Hierarchical groups (#3961) @dcavins is ready to commit the patch which has a cache invalidation scheme. @boonebgorges said patch looks good and mentioned testing the patch with thousands of groups. @dcavins is prepared to test with a group generator via WP-CLI.

Friends: Add caching to BP_Friends_Friendship class (#6978) @dcavins has refreshed patch which caches friendship objects separately from a users’ friendships.

Change bp_sort_by_key() to allow key preservation (#7238) @dcavins has patch, “If anyone has reservations about changing the underlying function call, please add a note on the ticket.”

Add action hook(s) outside the group admin form (#7249) @dcavins has patch. @boonebgorges, “seems fine to me.” @tw2113 “is fine to me too, it has its docs.” 😀 Update: This has been committed to trunk

No group members search in groupname/admin/manage-members/ (#6385) @dcavins has patch. Dev feedback needed.

Improve group management members screen (#7105) @dcavins has patch. @boonebgorges has posted comment in ticket. Update: This has been committed to trunk

Update BP_buttons class to accept new arg param for $element_type (#7226) @r-a-y requested feedback for current patch.

Group type frontend integration (#7210) @rayisme noted in ticket that he was going to commit patch soon. This has @boonebgorges‘ ♥ stamp.

Only load component action and screen code when we’re on the component’s page (#7218) @rayisme has patch. Dev feedback requested for relocating functions.

Screen notifications settings page (#6712) @rayisme has patches for a separate screen notifications panel as well as for a new merged notifications (email and screen) panel. @dcavins likes the “idea of a central place to manage communication.” @boonebgorges “I haven’t tested the patch, but I definitely like the idea of a central place for managing this stuff. I’ll check it out. What to do with 3rd-party settings doesn’t seem like a dealbreaker either way.”

Use WP page names for BP directory pages headings (#6765) @hnla requested dev feedback. @boonebgorges will look into this.

Display and filter by member type on Dashboard > Users (#6060) @dcavins has updated patch. Dev feedback requested – “a lookover would be great because this should easily apply to the groups wp-admin table with slight modification.” @boonebgorges will try to take a look.

Creation of developer.buddypress.org (#6812) @tw2113 has set up test site at https://trexthepirate.com/buddypress/

Slack log: https://wordpress.slack.com/archives/buddypress/p1473274934000113

#3961, #5451, #6060, #6385, #6712, #6765, #6812, #6978, #7105, #7210, #7218, #7226, #7238, #7249, #dev-chat

Dev Chat Summary for August 31, 2016

BuddyPress 2.7

Trac Tickets

BP-legacy: split group single admin.php in separate template files (#7079) @hnla has committed this to trunk. If you have copied over `groups/single/admin.php` and made some changes, there won’t be any changes to your theme. You might want to consider, however, “updating your file/s to the newer modular markup to enjoy improvements”, @dcavins said.

Improve `$args` included in ⁠⁠⁠⁠`bp_current_user_can`⁠⁠⁠⁠ and ⁠⁠⁠⁠`bp_user_can`⁠⁠⁠⁠ filters (#7192) @dcavins requested feedback from @rayisme who gave the nod. Update: @dcavins has committed patch to trunk.

Select All link missing in BuddyPress Menu Selection (#5260) @tw2113 has committed patch to trunk.

Extract & relocate core markup functions: Theme compat include functionality & search forms file (#6844) @boonebgorges has committed this to trunk.

Use WP page names for BP directory pages headings (#6765) @hnla, @imath, @boonebgorges, and @dcavins have contributed patches for this ticket and @rayisme has shared a code snippet. @hnla requested dev feedback.

strtotime() is evil don’t use it (#5781) @rayisme has committed patches for this ticket. He requests feedback on the `5781.mysql2date.patch`. “All of our `⁠⁠⁠⁠strtotime()⁠⁠⁠⁠` calls assume that GMT is the default timezone.  If the server’s timezone is anything but GMT, then our time rendering is wrong. Almost all of BP’s timestamps are in GMT.” Dev feedback requested.

Screen notifications settings page (#6712) @rayisme has patch. Dev feedback welcome.

Date xprofile field enhancement (#5500) @boonebgorges has updated patch. This ticket “is mostly done – just working out a couple of UI and acccessibilty issues near the end.”

BP Types UI

@boonebgorges and @dcavins will be developing the new dashboard UI for creating Member Types and Group Types as a plugin first. @boonebgorges has created the new repo at https://github.com/buddypress/bp-types-ui

Slack log: https://wordpress.slack.com/archives/buddypress/p1472669906000142

#5260, #5500, #5781, #6712, #6765, #6844, #7079, #7192, #dev-chat

Dev Chat Summary for June 1, 2016

BuddyPress 2.6.0 Beta 1

@dcavins packaged and released BuddyPress 2.6.0 Beta last Wednesday, June 1, 2016. Please help us test the exciting new features like the new API for Member/Group navigation, Activity embeds, Group Types API, and more!

BuddyPress 2.6.0 Schedule

  • Release Candidate 1 (string freeze): June 15, 2016
  • BuddyPress 2.6.0 release: June 22, 2016.
  • As of this post, there are 101 tickets in queue (Closed: 98. Open: 3.).

Trac Tickets

Companion Stylesheet – Twentyten and Twentyeleven (#7000) Kept open for any revision in stylesheet.

Add a “data-timestamp” attribute to all templates requiring timestamps (#5757) @rayisme needs more time to address localization issue. Update: This has been punted to BP 2.7.0.

Need to clear user cache after running direct query to update user displayname (#7050) Update: @djpaulgibbs has committed fix to trunk.

Activity link moderation doesn’t output useful error message to end users (#6719) Positive reviews during dev chat. Update: @rayisme has committed fix to trunk.

Use WP page names for BP directory pages headings (#6765) @boonebgorges would like to spend more time on the migration routine. “I think we’d been waiting for rewrite rules, but actually, we could build the UI first,” noted @boonebgorges. Update: This has been punted to Future Release.

Extract & relocate core markup functions: Theme compat include functionality & search forms file (#6844) Needed OK from Lead Dev. Update: Ticket has been punted to BP 2.7.0.

Emails: real unsubscribe functionality (#6932) Update: Ticket has been punted to BP 2.7.0.

Add a global scope option to the BP taxonomy wrapper functions (#7077) Ticket was reopened. @boonebgorges will take a look at it during Beta. Update: He has committed fixes to trunk.

oembed activity review (#7104) @rayisme has been committing fixes per review. Update: All review items have been fixed in trunk.

Slack log: https://wordpress.slack.com/archives/buddypress/p1464807686004763

#5757, #6719, #6765, #6844, #6932, #7000, #7050, #7077, #7104, #dev-chat

General Summaries for April 27 – May 4, 2016

This post covers the following meetings:
1. BP Template Pack on April 27 @ 18:00 UTC,
2. Dev Chat Summary on April 27 @ 19:00 UTC, and
3. Dev Chat Summary on May 4 @ 19:00 UTC.

BP Template Pack Meeting

Participants: @dcavins, @hnla, @im4th, and @mercime

  • @im4th: will open a new task about the activity post form to summarize what he has in mind so that we can discuss it.
  • @mercime: Google spreadsheets with screenshots of pages with current UI and how we would address each one of the component pages … then attach images of screens addressed in the next-template-pack for comparison
  • @hnla: has a draft of basic outline on bpdevel (not for publication at this time).
  • Use the Github repo Wiki pages for documentation
  • Review some wireframes made by @karmatosed in 2012 which already have feedback from the community as shown in BP Trac, bpdevel, and Github. We have to decide whether any of those can still be used or whether it would be better to make new wireframes.
  • Process: Discovery -> Design -> Development -> Launch.

Next meeting: Wednesday, May 11, same time (18:00 UTC), same #buddypress channel in Slack.

Dev Chat, April 27

A new API to manage single items navigation (#6534) @im4th has patch. Dev feedback requested. “The patch is replacing nav arrays with a new class. and make sure the nav is attached to an item ID. The user id for the displayed user nav or the group ID for the current group. Group nav and displayed user nav are separated – meaning there are no more slug collisions.” @boonebgorges and @im4th had a long discussion on the implementation in this Slack log. @im4th and @rayisme have uploaded patches after the meeting.

BP Users front.php (#6769) Kudos to @im4th from @rayisme and @boonebgorges for the mystery group avatar. @dcavins and @hnla said that they will test the patch and post feedback.

Dev Chat, May 4

A new API to manage single items navigation (#6534) @boonebgorges will be checking out the progress and at “how much we need to support old ways of reaching into the `bp_nav` and `bp_options_nav` globals and spending some time formalizing the various compatibility breaks with unit tests” Update: @boonebgorges has uploaded a new patch with unit tests.

BP Users front.php (#6769) @im4th has patch. Positive feedback during dev chat, testing welcome.

Audit all DB fetch methods to return integers where appropriate (#6977) @rayisme has patch. Work on this is about 90% done.

bp_send_email function not working with numeric string for $to argument (#7042) Will leave decision of ticket status to @djpaulgibbs.

BuddyPress Embeds for activity, user profiles, groups (#6772) @rayisme requested feedback on the display of the embeds in the template as well as the embeds template. Update: @mercime has posted feedback and @im4th has uploaded revised patch.

Screen notifications settings page (#6712) @rayisme: “I need to refresh #6712. @djpaulgibbs‘ feedback in the ticket was quite helpful for future iterations. I’m not sure if this can make 2.6 or not.”

Use WP page names for BP directory pages headings (#6765) Discussion between @hnla, @johnjamesjacoby, @im4th, and @boonebgorges resulted in the decision that this enhancement would require an migration for existing installations when they upgrade while new installations will get the shorter page names.

BuddyPress Style Modules: @hnla has provided the example one so it’s clear how they work and are formatted etc. at https://github.com/hnla/style-modules/tree/master/members-list-module. Update: A new Style Modules repo has been added to the BuddyPress account at https://github.com/buddypress/style-modules

Slack log: https://wordpress.slack.com/archives/buddypress/p1461780248000496

#6534, #6765, #6769, #6772, #6977, #7042, #buddypress, #dev-chat

Core Dev Chat Summary for February 3, 2016

Trac Tickets

Autoload BP classes (#6853) @boonebgorges noted the performance benefits in chat and in ticket. Update: “Rough benchmarks are showing a pretty consistent memory savings of between 1.5 and 2MB, on a local dev installation that has about a zillion plugins running … And with some further rearrangement in the future (so that components are loaded in a sleeker way) we could get that number down even further.”

All classes should be in their own files (#6870) @boonebgorges indicated that “it’s possible that full autoload (#6853) will reduce BP’s memory footprint by 10 or 20%” with the moves for all components. Update: This has been committed to core.

Comment syncing between activity and post comments for Custom Post Types (#6482) @im4th mentioned that the feature was not completed yet. Update: This feature has been committed to core.

Screen notifications settings page (#6712) @rayisme will be working to get this in for 2.5.0. Update: Refreshed patch has been uploaded.

BP_Attachment::get_image_data() unit test is failing due to upstream change (#6868) @im4th has created ticket in WP Core because BP unit tests for `BP_Attachment::get_image_data()` were failing due to changes upstream. Update: The fix has been committed to core.

Use WP page names for BP directory pages headings (#6765) @hnla requested dev feedback.

Accessibility: Provide sufficient color contrast in stylesheets to meet WCAG 2.0 AA standards (#6838) @mercime Update: This enhancement has been committed to core.

Suspension of BP comment moderation functionality (#6822)  @hnla and @boonebgorges discussed the pros and cons of removing BP comment moderation.

BuddyPress 2.5.0

  • Beta 1 is scheduled for today, February 8.
  • There are now 86 tickets slated for this cycle. (Closed: 73. Active: 13.)
  • From @boonebgorges: We’ll need to assemble a beta post by Monday. Traditionally, this has been a bullet-point list of big features, along with pointers to anything that needs special attention from users/developers testing the beta. I have outlined some of the new features already, but if people think of other things, they should speak up.

Slack log: https://wordpress.slack.com/archives/buddypress/p1454530078000766

#6482, #6712, #6765, #6822, #6838, #6868, #6870, #dev-chat

Dev Chat Summary for January 6, 2016

The first dev chat of the year focused on the 2.5.0 release scope. There are currently 104 tickets slated for  this dev cycle: 22 closed and 82 active. The following were mentioned during dev chat (major features have asterisks).

API

*BuddyPress Embeds for activity, user profiles, groups (#6772) @rayisme and @im4th work on ensuring that nested embeds show up as well as preventing embeds from breaking layout, among others.

*Create New Invitations API (#6210) @dcavins has written a bunch of tests for this feature in the last two releases. He’s currently working on the actual code changes and it’s going pretty well. Ultimately, he mentioned he’d like nearly all of the  features of Boone’s Invite Anyone plugin to be rolled in.

*A new API to manage single items navigation (#6534) @boonebgorges

*Email API and customisation features (#6592) @djpaulgibbs will be ready for review in a week or so. He has done lots of work on it and has recently posted an extensive technical update in ticket.

*Group Types API (#6784) @boonebgorges

BLOGS

*Comment syncing between activity and post comments for Custom Post Types (#6482) @im4th has patch which ready for  review/testing.

CORE

Use WP page names for BP directory pages headings (#6765) @hnla

Hooks Documentation Continued @tw2113

GROUPS

Add function to send single invitation (#6025) @dcavins is working on this in relation to the main ticket (#6210) Invitations API above.

NOTIFICATIONS

Comment notification NOT notified (#6057) @im4th will refresh the patch next week.

Screen notifications settings page (#6712) @rayisme

TEMPLATE PARTS

*Companion Stylesheet – Twenty Twelve (#6766) @hnla has committed the first pass of the SASS and compiled CSS files.

BP Users front.php (#6769) @hnla

XPROFILES

*xProfile fielddata visibility should be stored in xprofilemeta (#6413) @boonebgorges has the patch written, “just some work to do on making the migration routine less insane.”

*xProfile fields used for signup should be configurable (#6347) @johnjamesjacoby

xProfile field database schema (#6350) @johnjamesjacoby

BUDDYPRESS.ORG

*developer.buddypress.org (#5129) @tw2113 is working on the parser

GENERAL – ADMIN/UI

Accessibility Upgrades Continued @mercime

FOR NEXT WEEK:

  1. REST API
  2. “Social Network” vs. “Community Software” marketing direction

#5129, #6025, #6057, #6347, #6350, #6413, #6482, #6534, #6592, #6712, #6765, #6766, #6769, #6772, #6784, #dev-chat