Dev Chat Summary for April 29, 2015

BuddyPress 2.3.0 Schedule Update

  • BP 2.3.0 Beta 1 release has been postponed to next week because some features are not done yet (see trac tickets below). Deadline to complete feature for inclusion in BP 2.3.0 has been set this Saturday, May 2nd.
  • BP 2.3.0 RC 1 is scheduled two weeks before release ~ May 12th.
  • Target release date for 2.3.0 is May 26th, three days before BuddyCamp in Miami, Florida.

Star Private Messages

  • (#6331) @rayisme has a patch and is “just re-testing everything, but would appreciate some feedback on the general approach.” @johnjamesjacoby said he will be reviewing and testing the patch.
  • Update: @im4th and @boonebgorges have tested the patch and have given their feedback.

XProfile fields used for signup should be configurable

  • (#6347) @johnjamesjacoby mentioned that this still needs unit tests. He will get the tests in Friday “with a commit-ready patch for review.”

Attachment Library

  • (#6278) @im4th would like to commit the latest patch on this ticket. This last patch contains a back compatibility fix for versions of WordPress < 4.0.
  • Dev feedback needed.

Avatar UI

  • (#6290) @im4th mentioned that he would need to check for WP version compatibility since this UI requires Plupload 2.1.1 to maximize cross-browser compatibility. This version of the script was introduced in WP 3.9. While the general mantra is to check for feature compatibility and not version compatibility, @boonebgorges and @johnjamesjacoby gave thumbs up for the version check since this was the better course of action for this feature.
  • Update: This ticket is now a done deal. Testing and feedback welcome.

Update about the Blogs single items

  • (#6026) While this ticket was not discussed during this dev chat, it was previously tagged for 2.3.0 and bears mentioning. The team has decided to postpone it to 2.4 dev-cycle because of the sheer scope of the improvements suggested by @im4th in the patches.

Slack log: https://wordpress.slack.com/archives/buddypress/p1430333988003331
(You need a Slack account to view the logs.)

#activity

#6026, #6278, #6290, #6331, #6347, #dev-chat

Changes to bp_has_activities() queries in BP 2.1

Activity queries were largely overhauled in BuddyPress 2.0, leading to major performance improvements. These improvements were focused on the paginated query, the SELECT that contained a LIMIT clause based on the per_page value. The remaining bottleneck for activity pages on large installations was the other SELECT COUNT(*) query performed in BP_Activity_Activity::get() to get the total number of items matching the query params, a query that is much less amenable to optimization. The kicker is that the value returned by this query is almost never used in BuddyPress; the most common use for the total count figure is to generate pagination HTML, but by default, BuddyPress does not show true pagination for activity anywhere on the front end – just a generic “Load More” button at the bottom of the stream.

BuddyPress 2.1 will include changes to address this bottleneck. (See #5629 and r8491.) The SELECT COUNT(*) query will no longer take place by default, and the logic for displaying the “Load More” button has been altered to work without this query. Most sites will not notice any difference (except for the increase in speed!). However, there are a few cases where developers may need to make modifications to preserve some functionality:

  • noscript support – The “Load More” button on activity page uses Javascript. To cover browsers with JS disabled, a <noscript> block appeared in the activity-loop.php template that contained traditional pagination markup. This pagination will no longer generate properly as of BP 2.1. In BP’s bp-legacy templates, we have removed the <noscript> block and altered the “Load More” href to be populated by bp_activity_load_more_link(). However, if your theme is a bp-default derivative, or if you have overridden activity-loop.php in your theme, you will need to make the mods yourself to support non-JS browsers. Either reproduce the core change, or add count_total=count_query to the bp_has_activities() arguments.
  • Custom activity queries – If you have built a plugin or another customization that uses BP’s activity query functions (bp_has_activities(), bp_activity_get(), BP_Activity_Activity::get()), and if your customization relies on the 'total' or 'total_activity_count' value, you’ll need to make the necessary modifications to work properly with BP 2.1. In most cases, this just means passing 'count_total' => 'count_query' as one of the function args.

Apologies to those for whom this will cause an inconvenience – normally we try not to break backward compatibility for any reason, but it was impossible to ensure that all installations would receive the performance benefits without affecting a certain subset of installations (we did try to minimize impact).

Questions? Please ask in the comments below.

#5629, #activity, #bp_activity_activity, #bp_activity_get, #bp_has_activities

Today some primitive moderation functions were introduced to…

Today some primitive moderation functions were introduced to BuddyPress core to help combat unwanted submissions to your social network. These take advantage of the same Discussion Settings and illegal keys the WordPress Comments system uses to prevent them from being displayed immediately to your blogs’ audience.

This code currently exists in a new core component file named: bp-core-moderation.php
https://buddypress.trac.wordpress.org/browser/trunk/bp-core/bp-core-moderation.php

The Activity Stream is the first component to take advantage of this new ability. Any new Activity Stream updates that contain any of the illegal keys entered in your Discussion Settings will simply not be saved to the database. This is due to there currently not being a ‘moderation’ queue for activity stream items, which we may implement in a future version of BuddyPress.

The reason we are introducing this feature is simple: it’s your social network, and you reserve the right to keep your members safe from harassment and unfriendly interaction.

We’ll be testing this new feature over at testbp.org shortly, and hope you’ll test and report any issues you find!

#activity, #moderation